Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments to metaschema data types to align with Commonmark. #378

Conversation

david-waltermire
Copy link
Collaborator

@david-waltermire david-waltermire commented Jun 7, 2023

Committer Notes

This PR provides significant support for additional HTML tags in the markup-line and markup-multiline implementations.

Support is added for:

  • <hr/>
  • <blockquote>
  • <br>
  • <code class="someclass">

Titles are now allowed on <a title="sometitle"> and <img title="sometitle"/> tags. This was a major oversight.

List items (<li>) are now more robust in the content they allow. They now allow <pre>, <hr/>, and <blockquote>, headings, and <p> tags.

These schema changes support usnistgov/metaschema-xslt#9, usnistgov/metaschema-xslt#16, and usnistgov/metaschema-xslt#21.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

wendellpiez
wendellpiez previously approved these changes Jun 7, 2023
Copy link
Collaborator

@wendellpiez wendellpiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Dave.

@david-waltermire david-waltermire force-pushed the issue-70-109-221-commonmark-alignment branch from a8d9610 to d459c56 Compare June 7, 2023 18:58
@david-waltermire david-waltermire force-pushed the issue-70-109-221-commonmark-alignment branch from d459c56 to 5d036ac Compare June 8, 2023 14:03
Copy link
Collaborator

@wendellpiez wendellpiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-waltermire david-waltermire merged commit 62ad378 into usnistgov:develop Jun 8, 2023
@david-waltermire david-waltermire deleted the issue-70-109-221-commonmark-alignment branch June 8, 2023 15:42
@david-waltermire david-waltermire added this to the Metaschema 0.9.0 milestone Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants